Disable \Sabre\CalDAV\Schedule\Plugin #2
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baikal is no Groupware software, thus
\Sabre\CalDAV\Schedule\Plugin
can't provide any meaningful functionality "as is".\Sabre\CalDAV\Schedule\Plugin
relies on additional "transport" plugins to actually send invitations to attendees of events (see http://sabre.io/dav/scheduling/ for some details). AFAIK it was planned for Baikal 2 to additionally load\Sabre\CalDAV\Schedule\IMipPlugin
, however, I don't think that RFC 6047 (the standard behind\Sabre\CalDAV\Schedule\IMipPlugin
) is a good idea at all. The server sends invitations, but there's usually no way for the server to receive responses - so, it rather sends notifications than invitations? 😒sabre/dav
additionally supports server-to-server delivery, but afaik this isn't widely supported anyway. Furthermore it obviously won't work with local calendars.So, what's the reason for removing the plugin besides "it doesn't provide any functionality"?
I don't know a single calendar client that supports managing attendees, but not sending invitations. By loading
\Sabre\CalDAV\Schedule\Plugin
, Baikal claims to support scheduling - what is, as elucidated above, simply not the case. However, the calendar client (e.g. Thunderbird/Lightning) thinks Baikal supports scheduling and that invitations are handled by the server - and consequently disables its own invitation system. There's no way to overwrite this behavior - because it's simply not the client's fault, it's the server's (i.e. Baikal's) fault to falsely claim support for scheduling.By disabling
\Sabre\CalDAV\Schedule\Plugin
Baikal stops claiming support for scheduling, thus calendar clients will start sending invitations again.Closes sabre-io#685
Closes sabre-io#655
Fixes sabre-io#626
(+ many already closed, but never fixed Issues 😉)