Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup virtualenv for server. Fix PiPot/PiPot#7 #11

Merged
merged 9 commits into from
Mar 16, 2019

Conversation

VertexC
Copy link
Contributor

@VertexC VertexC commented Mar 2, 2019

Set up virtualenv during server install. Currently set up env under /usr/src/pipot/activate.

While it could be better to have a default name instead of letting user to input manually every time.

@VertexC VertexC changed the title setup virtualenv for server. Fix issue #7 setup virtualenv for server. Fix PiPot/PiPot#7 Mar 2, 2019
Copy link
Member

@canihavesomecoffee canihavesomecoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't activate the venv when the daemon starts after a reboot, so this is gonna cause issues.

Copy link
Member

@canihavesomecoffee canihavesomecoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did you test this out? :)

@VertexC
Copy link
Contributor Author

VertexC commented Mar 9, 2019

Sure I did :).

@canihavesomecoffee canihavesomecoffee merged commit a6944da into PiPot:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants