Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test:update with invalid service file #36

Merged
merged 1 commit into from
Aug 18, 2019

Conversation

VertexC
Copy link
Contributor

@VertexC VertexC commented Aug 17, 2019

No description provided.

@pep8speaks
Copy link

pep8speaks commented Aug 17, 2019

Hello @VertexC, Thank you for updating the PR!

Great work! I discovered no PEP8 issues in this Pull Request. 🥇

Comment last updated at 2019-08-17 08:26:22 UTC

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #36 into master will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   50.41%   51.02%   +0.61%     
==========================================
  Files          24       24              
  Lines        1799     1799              
==========================================
+ Hits          907      918      +11     
+ Misses        892      881      -11
Impacted Files Coverage Δ
mod_config/controllers.py 45.8% <0%> (+2.09%) ⬆️
pipot/services/ServiceLoader.py 62.71% <0%> (+8.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8675148...0e2c9b0. Read the comment docs.

@canihavesomecoffee canihavesomecoffee merged commit 86f8e51 into PiPot:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants