Add test on notification management, fix improper message when user upload the notification file #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @VertexC, Thank you for updating the PR! Great work! I discovered no PEP8 issues in this Pull Request. 🥇 Comment last updated at 2019-08-19 03:35:11 UTC |
VertexC
force-pushed
the
notificationTest
branch
3 times, most recently
from
664faf6
to
1b9be2e
Compare
|
Can you check why the tests fail? I see something with a missing module... |
|
Mmm, I should have install the python-telegram-bot in install_travis.sh, I'll take a look into this. |
VertexC
force-pushed
the
notificationTest
branch
from
1b9be2e
to
4b32904
Compare
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 51.02% 54.55% +3.52%
==========================================
Files 24 24
Lines 1799 1800 +1
==========================================
+ Hits 918 982 +64
+ Misses 881 818 -63
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now the server will start the thread and send back message as "notification is going to be listed as soon as said dependencies are installed", which is not true. The notification is listed only after user refreshes the page manually.