Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract convenience methods for getting/setting 16/24/32/64 bit values #1256

Closed
uweseimet opened this issue Oct 20, 2023 · 1 comment
Closed

Extract convenience methods for getting/setting 16/24/32/64 bit values #1256

uweseimet opened this issue Oct 20, 2023 · 1 comment
Assignees
@uweseimet

Comments

@uweseimet
Copy link
Contributor

The convenience methods for getting/setting 16/24/32/64 bit values in devices/scsi_command_util.cpp shall be moved into a separate helper class in the shared/ folder. At least scsidump can also make use of them.
@uweseimet uweseimet self-assigned this Oct 20, 2023
@rdmark rdmark mentioned this issue Oct 30, 2023
Merged
@uweseimet uweseimet moved this from To Do to In Progress in Release 23.11.01 (first Bookworm release) Oct 30, 2023
@uweseimet
Copy link
Contributor Author

uweseimet commented Oct 30, 2023 •
edited

It turned out that the data types required by scsidump for these methods differ from the existing ones, i.e. the code is similar but cannot be shared.

@rdmark This issue has become obsolete, i.e. it will not be included in the next release. Thus the only remaining PR from my side is #1274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uweseimet uweseimet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uweseimet