Add options to only run INQUIRY and to scan the bus to scsidump (#1092) #1261
Conversation
uweseimet
requested review from
akuker,
erichelgeson and
rdmark
as code owners
cpp/scsidump/scsidump_core.cpp
Outdated
| @@ -95,7 +99,7 @@ void ScsiDump::ParseArguments(span<char *> args) | |||
| int buffer_size = DEFAULT_BUFFER_SIZE; | |||
|
|
|||
| opterr = 0; | |||
| while ((opt = getopt(static_cast<int>(args.size()), args.data(), "i:f:s:t:rvp")) != -1) { | |||
| while ((opt = getopt(static_cast<int>(args.size()), args.data(), "i:f:s:t:rvpILS")) != -1) { | |||
There was a problem hiding this comment.
What is the "L" option that you add here?
There was a problem hiding this comment.
It's probably from a previous (temporary) change and I forgot to remove it. Now it's gone. I will merge soon.
Thank you for reviewing my PRs, by the way. I really appreciate it.
There was a problem hiding this comment.
@uweseimet You are very welcome, happy to help.
What do you say about next weekend, Saturday Nov 4, to tag the next stable release? Looking at the state of the project, you have two more TODO tickets planned, #975 and #1256 . Do you think you can finalize everything in the coming 4 days or do you need more time?
There was a problem hiding this comment.
@rdmark I just removed one of them from the next release, because it's not that important. The remaining one I can finalize immediately after my two remaining PRs have been merged. I cannot work on that ticket before because of potential merge conflicts.
Regarding the remaining 2 C++ PRs: If you also want to review them, please just go ahead ;-). I have already tested them quite a lot. Besides with scsictl #1262 has also been tested with my app.
There was a problem hiding this comment.
I almost missed that #1240 is still in progress, without a PR yet. But also this one can easily be finalized after merging the still open PRs.
uweseimet
moved this from In Progress
to Done
in Release 23.11.01 (first Bookworm release)
|
SonarCloud Quality Gate failed.
|
… (#1261) * Add options to only run INQUIRY and to scan the bus to scsidump
No description provided.