Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descriptive comments for each h/fdisk command #1106

Merged
merged 2 commits into from Feb 24, 2023
Merged

Descriptive comments for each h/fdisk command #1106

merged 2 commits into from Feb 24, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Feb 24, 2023

No description provided.

nucleogenic
nucleogenic approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@nucleogenic nucleogenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is documentation 💥

@rdmark rdmark merged commit 983cff7 into develop Feb 24, 2023
@rdmark rdmark deleted the rdmark-fdisk-error-handling branch February 24, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenic nucleogenic nucleogenic approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees
No one assigned
Labels
None yet
Projects
No open projects
PiSCSI Release after 23.02.01
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdmark @nucleogenic