Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code sharing and dependencies, address code duplication #976

Merged
merged 33 commits into from Nov 10, 2022
Merged

Improve code sharing and dependencies, address code duplication #976

merged 33 commits into from Nov 10, 2022

Conversation

uweseimet
Copy link
Contributor

@uweseimet uweseimet commented Nov 9, 2022 •
edited

Note: Most changes are related to include file paths changing, not to actual code changes. In order to further improve the file organization I added an additional folder "generated" for the generated protobuf interface files.

@uweseimet uweseimet added this to In progress in PiSCSI Rebrand Release Nov 9, 2022
@uweseimet uweseimet linked an issue Nov 9, 2022 that may be closed by this pull request
Move shared C++ code to separate sub-folder and improve sharing #967
Closed
@uweseimet uweseimet marked this pull request as ready for review November 9, 2022 16:41
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.5% 48.5% Coverage
0.0% 0.0% Duplication

akuker
akuker approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@akuker akuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uweseimet - Approved. Thanks!

@uweseimet uweseimet merged commit 4fa5130 into develop Nov 10, 2022
@uweseimet uweseimet deleted the feature-code-sharing branch November 10, 2022 06:44
@uweseimet uweseimet moved this from In progress to Done in PiSCSI Rebrand Release Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuker akuker akuker approved these changes

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

@rdmark rdmark Awaiting requested review from rdmark rdmark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
PiSCSI Rebrand Release
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move shared C++ code to separate sub-folder and improve sharing
2 participants
@uweseimet @akuker