Disable compiler warnings by default #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 11 11
Lines 223 223
=======================================
Hits 220 220
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ChrisThrasher
force-pushed
the
warnings_option
branch
from
f636505
to
d5c47aa
Compare
ChrisThrasher
changed the title
Unconditionally enabling -Werror is a heavy-handed approach and not ideal when shipping code to be used by many third parties. In fact it's even better to disable warnings by default since compiler warnings are not hard requirements. They're merely a development tool that developers should opt into.
ChrisThrasher
force-pushed
the
warnings_option
branch
from
d5c47aa
to
18168f1
Compare
|
Great, this is even better for us! |
tylerjw
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unconditionally enabling
-Werroris a heavy-handed approach and not ideal when shipping code to be used by many third parties. In fact it's even better to disable warnings by default since compiler warnings are not hard requirements. They're merely a development tool that developers should opt into.Closes #117