use only Twist not TwistStamped #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moriarty
commented
Jul 19, 2023
moriarty
commented
- This removes the TwistStamped. The Stamp information was unused.
- This makes it easier to use with teleop_twist_joy
- In the future we plan to add a TwistStamped version which can be configured
- This removes the TwistStamped. The Stamp information was unused. - This makes it easier to use with teleop_twist_joy - In the future we plan to add a TwistStamped version which can be configured Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 56 56
=====================================
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@abake48 this hasn't been tested on hardware yet. |
abake48
approved these changes
Jul 24, 2023
|
Perfect, I also tested this today: I will update the documentation in ros2_kortex and re-release everything |
moriarty
added a commit
to Kinovarobotics/ros2_kortex
that referenced
this pull request
Jul 25, 2023
- Related to PickNikRobotics/picknik_controllers#11 - Use Twist instead of TwistStamped because it works better with existing tools - Adds example to use with teleop_twist_keyboard Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
abake48
pushed a commit
to Kinovarobotics/ros2_kortex
that referenced
this pull request
Jul 26, 2023
- Related to PickNikRobotics/picknik_controllers#11 - Use Twist instead of TwistStamped because it works better with existing tools - Adds example to use with teleop_twist_keyboard Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.