Normalize interactive marker quaternions. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
reviewed
Jan 10, 2020
| control.orientation.x = 0; | ||
| control.orientation.y = 1; | ||
| control.orientation.y = 0.7071; |
There was a problem hiding this comment.
Should this be -0.7071 .? I used this website for illustration
There was a problem hiding this comment.
It seems to work fine (screenshot attached). I guess somebody else would have noticed if there was an issue, since I didn't change the sign.
There was a problem hiding this comment.
Note that the screenshot is after I dragged it around a bit
JafarAbdi
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quaternions for rotation should have a magnitude of 1