Don't enforce sorting of Spring resource locations #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ptijohn
commented
Aug 19, 2022
| "javax.xml.bind.annotation.XmlType#propOrder"); | ||
| "javax.xml.bind.annotation.XmlType#propOrder", | ||
| "org.springframework.test.context.TestPropertySource#locations", | ||
| "org.springframework.test.context.TestPropertySource#value"); |
There was a problem hiding this comment.
value and locations are aliases for each other:
There was a problem hiding this comment.
There's also @PropertySource; will add it :)
There was a problem hiding this comment.
Thanks @Stephan202 !
Stephan202
force-pushed
the
bdiederichs/ANS-1117
branch
from
cff1ed2
to
cd337d8
Compare
Stephan202
approved these changes
Aug 19, 2022
| "javax.xml.bind.annotation.XmlType#propOrder"); | ||
| "javax.xml.bind.annotation.XmlType#propOrder", | ||
| "org.springframework.test.context.TestPropertySource#locations", | ||
| "org.springframework.test.context.TestPropertySource#value"); |
There was a problem hiding this comment.
There's also @PropertySource; will add it :)
| @@ -144,7 +145,13 @@ void identification() { | |||
| " A secondEndpoint();", | |||
| "", | |||
| " @XmlType(propOrder = {\"field2\", \"field1\"})", | |||
| " class Dummy {}", | |||
| " class FirstDummy {}", | |||
There was a problem hiding this comment.
Let's use names that make future reordering less likely 😄
|
Suggested commit message: |
|
@rickie not clear what "there" refers to. Proposed something else. |
|
Thanks @Stephan202 and @rickie for the fast review + input! |
werli
approved these changes
Aug 19, 2022
rickie
changed the title
@TestPropertySource#locations/value from being sorted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All is in the title :)
Ticket is here: https://picnic.atlassian.net/browse/ANS-1117
Original context: https://github.com/PicnicSupermarket/picnic-store/pull/1596#discussion_r943618608