Introduce FluxCountMapMathToIntExact Refaster rule
#516
Conversation
|
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Tnx @Ptijohn! Added a commit with some suggestions. Suggested commit message:
Introduce `FluxCountMapMathToIntExact` Refaster rule (#516)
| @@ -805,6 +809,20 @@ Flux<T> after(Flux<? extends Iterable<T>> flux, int prefetch) { | |||
| } | |||
| } | |||
|
|
|||
| /** Prefer {@link Flux#count()} over collecting into a list and counting its elements. */ | |||
| static final class FluxCount<T> { | |||
There was a problem hiding this comment.
While it's an unwieldy name, likely we'll eventually name this rule FluxCountMapMathToIntExact (based on the @AfterTemplate code, so let's go for that.
| static final class FluxCount<T> { | ||
| @BeforeTemplate | ||
| Mono<Integer> before(Flux<T> flux) { | ||
| return flux.collect(toImmutableList()) |
There was a problem hiding this comment.
With CollectorMutability we also suggest toCollection(ArrayList::new) at times; let's add that case.
| @BeforeTemplate | ||
| Mono<Integer> before(Flux<T> flux) { | ||
| return flux.collect(toImmutableList()) | ||
| .map(Refaster.anyOf(Collection::size, ImmutableList::size, List::size)); |
There was a problem hiding this comment.
There's also ImmutableCollection::size 😄
There was a problem hiding this comment.
Of course!
Thanks :)
| Collection::size, | ||
| List::size, | ||
| ImmutableCollection::size, | ||
| ImmutableList::size)), |
There was a problem hiding this comment.
Yeah I hesitated on this one 😅
|
Looks good. No mutations were possible for these changes. |
rickie
changed the title
FluxCount Refaster rulesFluxCountMapMathToIntExact Refaster rule
Suggested commit message: