Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade oss-parent 0.0.2 -> 0.0.3 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade oss-parent 0.0.2 -> 0.0.3 #5

wants to merge 2 commits into from

Conversation

maxsumrall
Copy link
Member

Property override can be removed with an upgrade to the latest oss-parent when PicnicSupermarket/oss-parent#5 is merged.

@codecov-io
Copy link

codecov-io commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage     87.97%   87.97%           
  Complexity      117      117           
=========================================
  Files             8        8           
  Lines           291      291           
  Branches         26       26           
=========================================
  Hits            256      256           
  Misses            4        4           
  Partials         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdb6bf...b75f88a. Read the comment docs.

Stephan202
Stephan202 approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit. Suggested commit message:

Upgrade oss-parent 0.0.2 -> 0.0.3 (#5)

The primary change here is the upgrade of jOOQ from 3.11.11 to 3.12.1.

See:
- https://github.com/PicnicSupermarket/oss-parent/releases/tag/v0.0.3
- https://www.jooq.org/notes

scranen
scranen reviewed Oct 21, 2019
View reviewed changes
src/test/java/tech/picnic/jolo/UtilTest.java
assertFalse(withSchema.equals(FOO.ID));
assertFalse(FOO.ID.equals(noSchema));
assertFalse(noSchema.equals(FOO.ID));
assertTrue(noSchema.equals(FOO.ID));

// Also documenting this oddity: the qualified name of FOO.ID is not "PUBLIC.FOO.ID", even
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer true

@Stephan202 Stephan202 force-pushed the maxsumrall/update-jooq-3.12.1 branch from b75f88a to 6c295fe Compare April 23, 2021 20:57
Stephan202
Stephan202 reviewed Apr 23, 2021
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased.

@Stephan202 Stephan202 force-pushed the maxsumrall/update-jooq-3.12.1 branch from 6c295fe to ab72cd4 Compare April 23, 2021 21:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021 •
edited
Loading

Codecov Report

Merging #5 (ab72cd4) into sschroevers/fix-sonar-analysis (66e0f8e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                        Coverage Diff                        @@
##             sschroevers/fix-sonar-analysis       #5   +/-   ##
=================================================================
  Coverage                             89.20%   89.20%           
  Complexity                              118      118           
=================================================================
  Files                                     8        8           
  Lines                                   278      278           
  Branches                                 23       23           
=================================================================
  Hits                                    248      248           
  Misses                                    2        2           
  Partials                                 28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e0f8e...ab72cd4. Read the comment docs.

@Stephan202 Stephan202 changed the base branch from master to sschroevers/fix-sonar-analysis April 23, 2021 21:13
@Stephan202 Stephan202 changed the title Upgrade jOOQ 3.11.11 -> 3.12.1 Upgrade oss-parent 0.0.2 -> 0.0.3 (#5) Apr 23, 2021
@Stephan202
Copy link
Member

This PR is now on top of #13, for otherwise the build fails.

@Stephan202 Stephan202 changed the title Upgrade oss-parent 0.0.2 -> 0.0.3 (#5) Upgrade oss-parent 0.0.2 -> 0.0.3 Apr 23, 2021
Base automatically changed from sschroevers/fix-sonar-analysis to master May 6, 2021 12:01
@Stephan202 Stephan202 force-pushed the maxsumrall/update-jooq-3.12.1 branch from ab72cd4 to 290704a Compare May 6, 2021 12:03
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@scranen scranen scranen left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxsumrall @codecov-io @codecov-commenter @Stephan202 @scranen