Support Error Prone on Java 8-11 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Sep 8, 2018
| @@ -787,52 +803,35 @@ | |||
| <!-- We enable nearly all doclint checks, | |||
| except that we don't care about missing Javadoc | |||
| on non-public classes and members. --> | |||
| <arg>-Xdoclint:all</arg> | |||
| <arg>-Xdoclint:missing/protected</arg> | |||
| <arg>-Xdoclint:all,-missing/package</arg> | |||
There was a problem hiding this comment.
This change is not just "cleanup": the previous two-argument variant no longer works on JDK 11.
Stephan202
force-pushed
the
sschroevers/java-10-plus-support
branch
from
4c4c3dd
to
db543cb
Compare
nathankooij
approved these changes
Sep 10, 2018
.travis.yml
Outdated
| # XXX: On JDK 10 Error Prone causes warnings to be emitted; see | ||
| # https://github.com/google/error-prone/issues/860. | ||
| script: ./mvnw install -Dverification.warn | ||
| script: ./mvnw install | ||
| - jdk: openjdk-ea |
There was a problem hiding this comment.
Should we include oraclejdk-ea, too?
It also seems that openjdk11 is now available. (https://docs.travis-ci.com/user/languages/java/#using-java-10-and-later)
There was a problem hiding this comment.
Should we include
oraclejdk-ea, too?
Well, see #30 and travis-ci/travis-ci#9963 ;)
It also seems that
openjdk11is now available.
Good one; will try that.
There was a problem hiding this comment.
Just tested; oraclejdk-ea still fails. Added oraclejdk11 and openjdk11 :)
Stephan202
force-pushed
the
sschroevers/assorted-upgrades
branch
from
3873856
to
d9373f6
Compare
Stephan202
force-pushed
the
sschroevers/java-10-plus-support
branch
from
841d9c7
to
fa712ce
Compare
imTachu
approved these changes
Sep 12, 2018
nathankooij
approved these changes
Sep 12, 2018
Stephan202
force-pushed
the
sschroevers/assorted-upgrades
branch
from
d9373f6
to
01a0c83
Compare
Stephan202
force-pushed
the
sschroevers/java-10-plus-support
branch
from
b5d70d6
to
d96d313
Compare
Stephan202
force-pushed
the
sschroevers/assorted-upgrades
branch
from
01a0c83
to
40c0e94
Compare
The previous Error Prone setup only properly worked on Java 8 and 9. By configuring Error Prone as a javac plugin it now also successfully runs on Java 10 and above. Running the plugin under Java 8 requires a modest amount of extra configuration. While there: - Enable the `ConstructorLeaksThis` check now that the bug that was filed against it is fixed. - Drop the `-Xlint:-processing` flag because it seems the code now compiles fine without it.
And move flags that only have an impact when forking to the relevant location.
Stephan202
force-pushed
the
sschroevers/java-10-plus-support
branch
from
d96d313
to
e7e4a8c
Compare
Stephan202
changed the base branch from
sschroevers/assorted-upgrades
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Error Prone setup only properly worked on Java 8 and 9. By configuring Error Prone as a javac plugin it now also successfully runs on Java 10 and above. Running the plugin under Java 8 requires a modest amount of extra configuration.
While there:
ConstructorLeaksThischeck now that the bug that was filed against it is fixed.-Xlint:-processingflag because it seems the code now compiles fine without it.This PR is on top of #31. @imTachu, for various reasons upgrading our internal build will require more work than what is shown here, but as you can see proper Java 10+ support is inching closer :).
NB: the work in this PR proved not quite trivial; I opened google/error-prone#1115 so that it may be easier for the next person to try this.