Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For disabled date, date is clickable in Internet explorer 8 #288

Closed
rock2k3CS opened this issue Apr 9, 2015 · 1 comment
Closed

For disabled date, date is clickable in Internet explorer 8 #288

rock2k3CS opened this issue Apr 9, 2015 · 1 comment

Comments

@rock2k3CS
Copy link

When we use disable weekends feature of pikaday, the date buttons for disabled date is still clickable in IE8, as the css .is-disabled .pika-button has style 'pointer-events:none;' is only supported for IE9 and above.
As pikaday is supported for IE7 and above, please provide solution.
@esbenam
Copy link

esbenam commented Dec 2, 2015

This is still an issue.

There is an error in the _onMouseDown method when testing whether the button is disabled.

https://github.com/dbushell/Pikaday/blob/master/pikaday.js#L430

if (!hasClass(target, 'is-disabled'))

The is-disabled class is on the parentNode, so the code has to read

if (!hasClass(target.parentNode, 'is-disabled'))

I haven't read through the hole thing but it seems to do the trick.

Maybe this could be fixed on master, @dbushell?

dbushell added a commit that referenced this issue Feb 19, 2016
@dbushell
Merge pull request #477 from jdaudier/fix/IEselectBug
c47ec5e 
Make disabled buttons not clickable in IE 10 and below [closes #288]
DylanFM added a commit to DylanFM/Pikaday that referenced this issue Mar 2, 2016
@DylanFM
Merge branch 'master' into scss/add-variables
c87d015 
* master: (44 commits)
  Make disabled button not clickable in IE 10 and below [closes Pikaday#288]
  add formatStrict to Configuration section of README
  set default value for formatStrict option to false
  add options flag for strict date parsing with moment
  Add example to show days in next and previous months.
  Add simple disable day optional function example.
  don't change the container example
  correct data attributes for days in next and prev months
  Don't set pointer-events: none for days outside current month
  Show days in next and previous months
  Release 1.4.0
  [Pikaday#410] fixing invalid selector for next and prev buttons
  redraw after setMinDate() and setMaxDate() - fixes Pikaday#432
  remove data after pikaday destroy - fixes Pikaday#382
  don't change the container example
  correct data attributes for days in next and prev months
  Release 1.4.0
  redraw after setMinDate() and setMaxDate() - fixes Pikaday#432
  [Pikaday#410] fixing invalid selector for next and prev buttons
  Add triangle theme example.
  ...

Conflicts:
	scss/pikaday.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esbenam @rock2k3CS