Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New min/max dates for pickers in containers require hide and show #432

Closed
sobelk2 opened this issue Oct 22, 2015 · 2 comments
Closed

New min/max dates for pickers in containers require hide and show #432

sobelk2 opened this issue Oct 22, 2015 · 2 comments

Comments

@sobelk2
Copy link

sobelk2 commented Oct 22, 2015

I have a picker rendered into a container, and I routinely change minDate and maxDate using picker.setMinDate() and picker.setMaxDate(). However, by default, the new minDate or maxDate does not take effect until I navigate to a new month in the picker. The workaround for this is to hide and show the picker immediately after setting a new minDate or maxDate. I do not believe this should be necessary. This bug only occurs for pickers rendered into a container.

@sobelk2 sobelk2 changed the title New min/max dates for pickers in containers require hide show New min/max dates for pickers in containers require hide and show Oct 22, 2015
@nathancahill
Copy link
Contributor

Good call, I'll take a look at this. Should be an easy fix.

@sobelk2
Copy link
Author

sobelk2 commented Oct 23, 2015

Thanks!

rikkert pushed a commit to rikkert/Pikaday that referenced this issue Nov 13, 2015
DylanFM added a commit to DylanFM/Pikaday that referenced this issue Mar 2, 2016
* master: (44 commits)
  Make disabled button not clickable in IE 10 and below [closes Pikaday#288]
  add formatStrict to Configuration section of README
  set default value for formatStrict option to false
  add options flag for strict date parsing with moment
  Add example to show days in next and previous months.
  Add simple disable day optional function example.
  don't change the container example
  correct data attributes for days in next and prev months
  Don't set pointer-events: none for days outside current month
  Show days in next and previous months
  Release 1.4.0
  [Pikaday#410] fixing invalid selector for next and prev buttons
  redraw after setMinDate() and setMaxDate() - fixes Pikaday#432
  remove data after pikaday destroy - fixes Pikaday#382
  don't change the container example
  correct data attributes for days in next and prev months
  Release 1.4.0
  redraw after setMinDate() and setMaxDate() - fixes Pikaday#432
  [Pikaday#410] fixing invalid selector for next and prev buttons
  Add triangle theme example.
  ...

Conflicts:
	scss/pikaday.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants