New option "firstWeekOfYearMinDays" for regional week numbering rules support #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josundt
changed the title
|
merged thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new option firstWeekOfYearMinDays to support regional variations in week numbering rules. The new option makes it possible to support world-wide rule variations - when not using moment.
The change extends Pikaday's week number support which is currently limited to the ISO 8601 week numbering rule (week 1 = the first week with 4 days - considering Monday as the first day of the week).
https://en.wikipedia.org/wiki/ISO_week_date
The new added option is not mandatory and has a default value of 4, which means Pikadays current behavior is not altered when the option is not specified, it will default to the ISO 8601 rule.
(In the project I am currently working on, I already have the firstWeekOfYearMinDays rule available since cldr-data is loaded for the current user's region/culture (https://github.com/unicode-cldr/cldr-core/blob/master/supplemental/weekData.json).
The only small shortcoming I faced with respect to week numbers in Pikaday was to have the option that I implemented in this PR.