Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] Use math.radians() to compute default values in launch-files #284

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

martiniil
Copy link
Contributor

@martiniil martiniil commented Nov 25, 2021

Description

These changes make the choice of the default angular values more understandable.


PR Checklist

Things to add, update or check by the maintainers before this PR can be merged.

  • Public api function documentation
  • Architecture documentation reflects actual code structure
  • Tutorials
  • Overview on ROS wiki
  • Package Readme (example pilz_robots)
  • Good commit messages (some tips)
  • CHANGELOG.rst updated
  • Copyright headers
  • Examples

Review Checklist

  • Soft- and hardware architecture (diagrams and description)
  • Test review (test plan and individual test cases)
  • Documentation describes purpose of file(s) and responsibilities
  • Code (coding rules, style guide)

Release planning (please answer)

  • When is the new feature released?
  • Which dependent packages do have to be released simultaneously?

Hardware tests

Unstrike the text below to enable automatic hardware tests if available. Otherwise use this as a request for the reviewer.

  • Perform hardware tests

@martiniil martiniil marked this pull request as draft November 25, 2021 08:40
@martiniil martiniil force-pushed the feature/ros2_launch_eval_math branch from 42b1331 to 75599b1 Compare January 31, 2022 13:21
@martiniil martiniil marked this pull request as ready for review January 31, 2022 13:37
@martiniil martiniil force-pushed the feature/ros2_launch_eval_math branch from 779f63c to 2771dec Compare July 27, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant