Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foxy] Evaluate math symbols and functions in python expression (#557) #562

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

martiniil
Copy link
Contributor

  • Evaluate math symbols and functions in python expression

Signed-off-by: Immanuel Martini i.martini@pilz.de

  • Format docstring

Signed-off-by: Jacob Perron jacob@openrobotics.org

Co-authored-by: Jacob Perron jacob@openrobotics.org

* Evaluate math symbols and functions in python expression

Signed-off-by: Immanuel Martini <i.martini@pilz.de>

* Format docstring

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI !

@adityapande-1995
Copy link
Contributor

adityapande-1995 commented Dec 20, 2021

Foxy CI :
build : --packages-above-and-dependencies launch
test : --packages-above launch

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@martiniil
Copy link
Contributor Author

@adityapande-1995 do I have to worry about the unstable builds?

@adityapande-1995
Copy link
Contributor

adityapande-1995 commented Dec 22, 2021

The error with rosbag2 is a known issue : ros2/rosbag2#927.
The issue with ros2doctor seems to be unrelated. Running CI on vanilla foxy to verify :

  • Windows : Build Status
  • MacOS : Build Status

The error happened even without the changes in this PR, so the problem is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants