Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

✨ Middleware implementation #82

Closed
Arthurdw opened this issue Sep 30, 2021 · 14 comments · Fixed by #124, #163 or #174
Closed

✨ Middleware implementation #82

Arthurdw opened this issue Sep 30, 2021 · 14 comments · Fixed by #124, #163 or #174
Labels
easy issue isn't hard to resolve enhancement New feature or request

Comments

@Arthurdw
Copy link
Member

Arthurdw commented Sep 30, 2021

Most middleware still has to be implemented.

Some files are already present in pincer.middleware.

Find the events here

@Arthurdw Arthurdw added enhancement New feature or request Hacktoberfest Role for hacktoberfest easy issue isn't hard to resolve labels Sep 30, 2021
@Sigmanificient Sigmanificient changed the title Middleware implementation ✨ Middleware implementation Oct 3, 2021
@Sigmanificient
Copy link
Member

sure!

@yashpy yashpy removed their assignment Oct 4, 2021
@krishnajalan
Copy link
Contributor

hello, I want to pick up this issue.

@Arthurdw
Copy link
Member Author

Arthurdw commented Oct 4, 2021

hello, I want to pick up this issue.

Sure :D

@Sigmanificient Sigmanificient linked a pull request Oct 5, 2021 that will close this issue
2 tasks
@Arthurdw Arthurdw removed a link to a pull request Oct 5, 2021
2 tasks
@Sigmanificient Sigmanificient linked a pull request Oct 5, 2021 that will close this issue
2 tasks
@Arthurdw
Copy link
Member Author

Arthurdw commented Oct 6, 2021

Not all middleware has been implemented yet :)
Thanks @krishnajalan for your contributions tho ♥

@Enderchief
Copy link
Member

If anyone wants to finish this. here are the middlewares that have not been implemented or do not have an export method.
(list from logs)

@Lunarmagpie
Copy link
Member

Lunarmagpie commented Oct 11, 2021

I can look at whats left in this one. Should be a good way for me to figure out how the hell middleware works lol.

Edit: Been having a lot of trouble with this. I can't get notification_create to work properly at all.

@Enderchief
Copy link
Member

Enderchief commented Oct 19, 2021

Looking through the discord api docs, other that the ones listed above, there are still some left to implement. @Arthurdw linked to the RPC events when we should be checking the gateway events. This issue can be split up between multiple people.
Here are the events not yet added (if it's checked, it has been added or someone is working on it):

@Enderchief
Copy link
Member

I can work on some of these too. I will start with Channel Update, Channel Delete, Channel Pins Update. Feel free to take some of the other ones.

@Enderchief Enderchief self-assigned this Oct 23, 2021
@Lunarmagpie
Copy link
Member

Im working on all of the Guild Member ones. I think I should have a PR in a few hours.

@Enderchief Enderchief mentioned this issue Oct 24, 2021
2 tasks
@Lunarmagpie
Copy link
Member

#162 should probably mention this too lol

@Arthurdw Arthurdw removed the Hacktoberfest Role for hacktoberfest label Nov 1, 2021
@beastmatser
Copy link
Contributor

I added the last middleware, the code is on a pull request for the branch in #163 , so @Endercheif if you could merge it, so that it can be reviewed that would be awesome :)

@Enderchief
Copy link
Member

Updating this list right now for the things that @beastmatser added in #174

@beastmatser
Copy link
Contributor

Guild Integrations Update and Webhooks Update are now also added in #174

@Enderchief
Copy link
Member

This has been finished. Just waiting on #163 and #174 to be merged.

This was linked to pull requests Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
easy issue isn't hard to resolve enhancement New feature or request
Projects
None yet
7 participants