This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
🎨 Middleware no longer returns API objects in list #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 9 9
Lines 100 100
=======================================
Hits 90 90
Misses 10 10 Continue to review full report at Codecov.
|
Sigmanificient
suggested changes
Nov 27, 2021
trag1c
approved these changes
Nov 27, 2021
Enderchief
approved these changes
Nov 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
improvements: Middleware doesn't return API objects in a list since it wasn't used once after implemented all the documented Middleware. This let me simplify the code in Client and EventMgr.Check off the following