Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

Nox stuff #469

Merged
merged 9 commits into from
Jun 3, 2022
Merged

Nox stuff #469

merged 9 commits into from
Jun 3, 2022

Conversation

Enderchief
Copy link
Member

Changes

It has come to my attention that many of the measure we have in place are not being run or used as much. Nox will fix that.
Before doing a pr, on can run nox on their local machine to run tests and lints. As a workflow, they will also run.

Check off the following

  • I have tested my changes with the current requirements
  • My Code follows the pep8 code style.

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #469 (50f9049) into main (9b3f62b) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   65.01%   64.83%   -0.18%     
==========================================
  Files         183      184       +1     
  Lines        5968     5984      +16     
==========================================
  Hits         3880     3880              
- Misses       2088     2104      +16     
Impacted Files Coverage Δ
noxfile.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3f62b...50f9049. Read the comment docs.

@Sigmanificient
Copy link
Member

What is tox doing?

@Enderchief
Copy link
Member Author

What is tox doing?

tox (thing I removed) did nothing because it was never integrated into the code base, it was an extra dependancy. nox (what I added) runs black, isort, flake8, pytest, mypy all in one command. Prior to this, it was clear many had not ran these individually as they were supposed to. nox makes it easy and will also auto run as a GitHub workflow

@Sigmanificient
Copy link
Member

Sigmanificient commented May 28, 2022

What is tox doing?

tox (thing I removed) did nothing because it was never integrated into the code base, it was an extra dependancy. nox (what I added) runs black, isort, flake8, pytest, mypy all in one command. Prior to this, it was clear many had not ran these individually as they were supposed to. nox makes it easy and will also auto run as a GitHub workflow

We maybe dont want to run mypy with a workflow cause there is a lot of type errors currently, and it's gonna fail for pretty much a while

@Enderchief Enderchief added the CI Continuious intregration label May 28, 2022
@Sigmanificient
Copy link
Member

nox still failling xD

.github/workflows/ci.yml Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Enderchief and others added 2 commits May 29, 2022 16:22
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
@Sigmanificient
Copy link
Member

Can we just format the coe with black one and for all?

@Enderchief
Copy link
Member Author

The only reason the Nox is failing, is because the code is not formatted correctly.
We have two options.

  • Merge this now and in a different PR resolve the formatting issue or
  • In this PR, format it.

I would say the second one just to keep the PRs organized.

Copy link
Member

@Arthurdw Arthurdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me.

@Enderchief Enderchief merged commit ee94f9f into Pincer-org:main Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Continuious intregration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants