-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
Codecov Report
@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 65.01% 64.83% -0.18%
==========================================
Files 183 184 +1
Lines 5968 5984 +16
==========================================
Hits 3880 3880
- Misses 2088 2104 +16
Continue to review full report at Codecov.
|
What is tox doing? |
tox (thing I removed) did nothing because it was never integrated into the code base, it was an extra dependancy. nox (what I added) runs black, isort, flake8, pytest, mypy all in one command. Prior to this, it was clear many had not ran these individually as they were supposed to. nox makes it easy and will also auto run as a GitHub workflow |
We maybe dont want to run mypy with a workflow cause there is a lot of type errors currently, and it's gonna fail for pretty much a while |
nox still failling xD |
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Can we just format the coe with black one and for all? |
The only reason the Nox is failing, is because the code is not formatted correctly.
I would say the second one just to keep the PRs organized. |
🎨 Finally fixing black & flake8 (Pincer-org#474)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me.
Changes
It has come to my attention that many of the measure we have in place are not being run or used as much. Nox will fix that.
Before doing a pr, on can run
nox
on their local machine to run tests and lints. As a workflow, they will also run.Check off the following