Support loading icons from other assemblies (e.g. Plugins) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetIcon() does not support loading icons if the icon is in the resource of a different assembly. This is needed to support icons in plugins.
|
This is a sensible improvement, and the logic looks sound! (I remember looking into this section at some point in the past.) However, the indentation is messed up, it looks like a classic case of tabs versus spaces. If you you translate the spaces into tabs as is the custom in this codebase so that everything looks right, I'll be happy to merge this. |
|
Updated intends (by replacing 4 spaces with tab, don't know why mono used spaces...) |
|
Cool, thanks! Like I said, I feel confident mergin this PR but the others will have to wait for review from someone more knowledgable. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetIcon() does not support loading icons if the icon is in the resource of a different assembly. This is needed to support icons in plugins.