Port to GtkSharp 3 all the Gtk# 2 dock system #148

Dadoum · 2020-10-02T15:56:34Z

No description provided.

cameronwhite · 2020-10-03T13:45:19Z

Thanks for working on this! I'll look through it later this weekend and give it a test

Dadoum · 2020-10-03T17:42:45Z

I have some improvement I've done for Windows style if needed
But it will remove native-like titlebars on Linux?

cameronwhite · 2020-10-03T22:02:38Z

I'd be interested to see the changes! Most likely it would be safest to stick with the default GTK style / behaviors where possible though

Dadoum · 2020-10-03T22:36:00Z

All colours are taken from GTK+ 3 theme. The icon are drawn, but we can mix up both code if native decorations are preferred.

Dadoum · 2020-10-03T22:37:10Z

It also fixes some bugs, but there is still some features that could be miss-implemented. The tool stays mostly usable tho.

Dadoum · 2020-10-03T22:46:25Z

If I don't answer, and if you prefer the old version, you can revert the last commit.

cameronwhite · 2020-10-05T22:33:27Z

Gave it a test on my Mac and it's working pretty well!
A few issues I noticed (see screenshot below)

Some of the dock items have a close button but the dock item isn't supposed to be closeable. This seems to go away after minimizing and restoring the panel
There is some extra padding around all of the dock items, but that might be coming from the GTK3 theme?
The text for the dock item's title seems small and kind of blurry
The toolbars in the history pad and layers pad are showing up at the top instead of the bottom

Dadoum · 2020-10-21T15:50:47Z

Just an update: I am actually porting the docking library of master Pinta branch. Should not take too long; almost everything works great except appearance.

cameronwhite · 2020-10-21T20:45:32Z

OK, sounds good!

Dadoum · 2020-10-23T23:14:56Z

Done ! Can you try on macOS everything ? (don't own any mac)
Should work better too on dark gtk theme.

Dadoum · 2020-10-24T00:03:38Z

After more search for issues, I found 2 issues/differences with Gtk#2:

No radial effect when hovering dockbar button
Bad colours on tab strip with some gtk theme
Will fix when I will find time

Dadoum · 2020-10-24T10:13:58Z

Another big issues:

TabBar is horrible.
shares a bug with gtk#2 implementation, it cannot be moved from dock title bar (not window one) on another undocked place.

Dadoum · 2020-10-26T21:58:27Z

All known issues are now fixed.

cameronwhite · 2020-10-26T23:59:49Z

Great, I'll have a look soon!

Dadoum · 2020-10-27T01:00:18Z

Some screens on Linux:

Screenshot on Gnome with Arc-Darker

Screenshot on Gnome with Arc-Dark

Screenshot on Gnome with Adwaita-Dark

cameronwhite · 2020-10-27T20:23:54Z

The screenshots look very good! In the third screenshot, is the black text on black background for "Unsaved image 1" something that can be fixed, or is it a problem with the theme?

Dadoum · 2020-10-27T23:00:20Z

I don't know why, I try to get "text_color" property. The only fix I see is to change this text by a Label.

But it works with most themes. I tested with Yaru (ubuntu theme), its dark varient and it works too.

I also tested with Gtk's win32 theme (on Windows), and if there will be Windows distribution, there should be a theme with it because everything is ugly on Windows.

cameronwhite

Thanks for all this work!
I've left a few questions and suggestions in the comments

From testing on macOS (see screenshot below) the only issues I noticed were the missing icons (black squares beside the dock pad titles) and the inactive tab being drawn in black
I think the icon issue is from the changes to use themed icons in the GTK3 branch - my comment in HistoryPad.cs has a fix that should probably work

cameronwhite · 2020-10-28T21:56:55Z

Pinta.Docking/Extensions/GtkWorkarounds.cs

+using System.Windows.Input;
+#endif
+
+namespace Hexadock


Is there a reason for this Hexadock namespace rather than e.g. Pinta.Docking? I'm not clear what its origin is

This come from one of my side projects, since when I ported Gtk#2 Docking, it was first for my side project named Hexacode. Will rename it

cameronwhite · 2020-10-28T22:04:54Z

Pinta.Docking/DockLibrary/DockItem.cs

+
+			// Hide menuitem
+			if ((Behavior & DockItemBehavior.CantClose) == 0) {
+				MenuItem mitem = new MenuItem (("Hide"));


I think this were translatable strings in the master branch? (using Catalog.GetString()). In the GTK3 build you can use Pinta.Core.Translations, but we could move that elsewhere if needed for Pinta.Docking to depend on it.

I referenced now Pinta.Core (for peaople that would want to use Pinta.Docking, it will not be so hard to remove it)

Ok, sounds good!

cameronwhite · 2020-10-28T22:06:30Z

Pinta.Docking/DockLibrary/DockItemTitleTab.cs

+			btnDock = new ImageButton ();
+			btnDock.Image = pixAutoHide;
+            btnDock.InactiveImage = pixAutoHide.WithAlpha (.5);
+            btnDock.TooltipText =  ("Auto Hide");


The tooltips here should also be translatable.

cameronwhite · 2020-10-28T22:15:51Z

Pinta.Docking/Folder.DotSettings.user

@@ -0,0 +1,2 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">


I think this file should be removed?

cameronwhite · 2020-10-28T22:20:13Z

Pinta.Docking/Pinta.Docking.csproj

+
+  <!-- References -->
+  <ItemGroup>
+    <Reference Condition=" '$(PINTA_MONO_POSIX_2)' != '' " Include="Mono.Posix, Version=2.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756, processorArchitecture=MSIL" />


This might have been copied over from the master branch, but isn't necessary for GTK3
Could you revert some of this file to match the current gtk3-v2 branch? e.g. adding back the

<Version>1.8.0.0</Version> <Authors>PintaProject</Authors> <Company /> <Product />

cameronwhite · 2020-10-28T22:26:38Z

Pinta/Pads/HistoryPad.cs


-			// TODO-GTK3 (docking)
-#if false
+			history_item.Label = ("History");


This string should be translatable (Translations.GetString())

cameronwhite · 2020-10-28T22:27:08Z

Pinta/Pads/HistoryPad.cs

-			history_item.Icon = Gtk.IconTheme.Default.LoadIcon(Resources.Icons.LayerDuplicate, 16);
-			history_item.DefaultWidth = 100;
+			history_item.Content = history;
+			history_item.Icon = PintaCore.Resources.GetIcon ("Menu.Layers.DuplicateLayer.png");


In the GTK3 build we now use themed icons, so I think this should be Gtk.IconTheme.Default.LoadIcon(Resources.Icons.LayerDuplicate, 16); from the deleted line above?

cameronwhite · 2020-10-28T22:27:47Z

Pinta/Pads/LayersPad.cs

-			layers_item.DefaultWidth = 100;
+			layers_item.Label =  ("Layers");
+			layers_item.Content = layers;
+			layers_item.Icon = PintaCore.Resources.GetIcon ("Menu.Layers.MergeLayerDown.png");


Similar issues with label and icon as the other dock pads.

cameronwhite · 2020-10-28T22:28:03Z

Pinta/Pads/OpenImagesPad.cs

 			open_images_item.DefaultLocation = "Layers/Bottom";
+			open_images_item.Label = ("Images");
 			open_images_item.Content = new OpenImagesListWidget ();
 			open_images_item.Icon = PintaCore.Resources.GetIcon ("Menu.Effects.Default.png");


Similar issues with label and icon as the other dock pads.

cameronwhite · 2020-10-28T22:28:12Z

Pinta/Pads/ToolBoxPad.cs

 			toolbox_item.Content = toolbox;
-			toolbox_item.Icon = Gtk.IconTheme.Default.LoadIcon(Resources.Icons.ToolPencil, 16);
+			toolbox_item.Icon = PintaCore.Resources.GetIcon ("Tools.Pencil.png");


Similar issues with label and icon as the other dock pads.

Dadoum · 2020-10-29T02:07:31Z

Translations now fully working, setupping a macOS KVM to start debugging background system.

darkdragon-001 · 2021-02-10T22:35:38Z

This looks very promising. Anything still blocking this from being merged?

Dadoum · 2021-02-10T22:36:52Z

Yes, it is still ugly on macOS, I had a working branch but I lost it with a disk corruption.

darkdragon-001 · 2021-02-11T01:52:25Z

@Dadoum Sad to hear that! Hopefully you can still remember the important twists such that you can quickly redo your work. Looking forward to your changes!

Dadoum · 2021-02-12T21:05:40Z

Going to rearchitect DockNotebook to make it use native components. This is the preferred approach in gtk 4

Dadoum · 2021-02-27T14:22:04Z

Just need some details about how it should be reimplemented. Now, the gtk3-v2 branch uses panels for 2 elements only (history and layers) and the notebook. It is maybe overkill to use it just for two panels ? Or should I recreate panels ? This would be a big rollback.

cameronwhite · 2021-03-02T01:22:58Z

I'd say try keeping the UI as-is with the latest version (so history / layers panel plus the notebook) and see how things look!

Dadoum force-pushed the gtk3-v2 branch from cee625d to 81a0fdd Compare October 23, 2020 22:37

Dadoum changed the title ~~Port to gtk3 all docking of MonoDevelop 2.3~~ Port to GtkSharp 3 all the Gtk# 2 dock system Oct 23, 2020

cameronwhite reviewed Oct 28, 2020

View reviewed changes

cameronwhite mentioned this pull request Dec 9, 2020

[Prototype] Explore cleaned up UX. #151

Closed

Dadoum force-pushed the gtk3-v2 branch from df9af68 to b658f0a Compare February 12, 2021 21:04

Dadoum closed this Apr 14, 2021

Dadoum force-pushed the gtk3-v2 branch from b658f0a to 077ca6d Compare April 14, 2021 14:30

		@@ -0,0 +1,2 @@
		<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">

Port to GtkSharp 3 all the Gtk# 2 dock system #148

Port to GtkSharp 3 all the Gtk# 2 dock system #148

Conversation

Dadoum commented Oct 2, 2020

cameronwhite commented Oct 3, 2020

Dadoum commented Oct 3, 2020

cameronwhite commented Oct 3, 2020

Dadoum commented Oct 3, 2020 • edited

Dadoum commented Oct 3, 2020

Dadoum commented Oct 3, 2020

cameronwhite commented Oct 5, 2020

Dadoum commented Oct 21, 2020

cameronwhite commented Oct 21, 2020

Dadoum commented Oct 23, 2020

Dadoum commented Oct 24, 2020

Dadoum commented Oct 24, 2020 • edited

Dadoum commented Oct 26, 2020

cameronwhite commented Oct 26, 2020

Dadoum commented Oct 27, 2020

cameronwhite commented Oct 27, 2020

Dadoum commented Oct 27, 2020 • edited

cameronwhite left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dadoum commented Oct 29, 2020

darkdragon-001 commented Feb 10, 2021

Dadoum commented Feb 10, 2021

darkdragon-001 commented Feb 11, 2021

Dadoum commented Feb 12, 2021

Dadoum commented Feb 27, 2021

cameronwhite commented Mar 2, 2021

Dadoum commented Oct 3, 2020 •

edited

Dadoum commented Oct 24, 2020 •

edited

Dadoum commented Oct 27, 2020 •

edited