Fix Ruler rendering issue. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was for making the text have a vertical layout - here's how it looks on my Mac: I'm okay with switching to rotated text though, if that makes it work on every platform :) |
|
Looking at Inkscape's ruler widget (which was also ported to GTK3 to replace the built-in ruler from GTK2), they draw each digit separately to get vertical text rather than using the gravity controls. So, I think that would be the approach to take if we want to go back to having vertical rather than rotated text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you know what the intent behind these Gravity flags is? Using one of them is fine, but when using both of them it causes the values to be written as squares. (Win10)
This PR fixes this by removing the flags and moving the text into place, but it may not be the correct fix. 🤷♂️