release-2.1 branch: migrate from net7 to net8
#763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronwhite
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks for looking at this!
I'm fine with doing a minor release to allow building against .NET 8, but I'd prefer doing the 2.1.2 version bump in a separate commit so that it's easier to review. Could you strip this down to just the .NET 8 changes please?
I think we should also port over the changes from the master branch which fixed issues where the .net6.0 CI build didn't actually build against .NET 6, to ensure that no regressions occur for that configuration (68b8f07)
|
Fixed as requested. |
|
Looks good, thanks! |
|
@cameronwhite can you assign Milestone 2.1.2 to this issue also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net7 EOL is coming soon (May 14, 2024).
It looks like we need to release version
2.1.2that only migrates2.1.1from net7 to net8.