+ New feauture from wishlist: drag'n'drop pictures from web browser\n* F... #80
Conversation
…* Fixed: OpenImagesListWidget caused NullPointerException when clicked fast more than one times.
| System.Net.WebClient client = new System.Net.WebClient (); | ||
| string tempFilePath = System.IO.Path.GetTempPath () + System.IO.Path.GetFileName(file); | ||
|
|
||
| Console.WriteLine (">>File downloaded; " + file + "; " + tempFilePath); |
There was a problem hiding this comment.
I think the error handling and progress notifications need to be improved here (e.g. showing dialogs instead of dumping messages to the console).
| if (file.StartsWith ("file://")) | ||
| PintaCore.Workspace.OpenFile (new Uri (file).LocalPath); | ||
| try { | ||
| PintaCore.Workspace.HasOpenPendingDocuments = true; |
There was a problem hiding this comment.
I'm not clear why HasOpenPendingDocuments is necessary?
There was a problem hiding this comment.
As far as I remember not setting this flag up could lead to something like NullPointerException or so in case of user trying to open more than one document at the same time.
There was a problem hiding this comment.
IMO it should be removed - the only place it's checked is inside WindowPointToCanvas, but mouse events shouldn't be handled while an image is being downloaded. The progress dialog should be a modal dialog, while the image is downloaded in the background.
|
Any news here? |
- Remove the HasPendingOpenDocuments member, which shouldn't be necessary. - Make the strings translatable. - Ensure that the new image isn't marked as being associated with a file, so that the user can't save to the temp file and later lose their work. #80
...ixed: OpenImagesListWidget caused NullPointerException when clicked fast more than once