Cursor of mouse feature #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cursor.PaintBucket.png added also to resources, to Pinta.Resources.csproj&makefile and to PaintBucketTool.cs
Cursor.PaintBucket.png added also to resources, to Pinta.Resources.csproj&makefile and to PaintBucketTool.cs
added the png Cursor.LassoSelect.png and added it to resources (to csproj & makefile)
added the png Cursor.Text.png and added it to resources (to csproj & makefile)
added the 2 corresponding pngs and added those to the makefile.am and resources.csproj additionally: in LineCurveTool changed the endlines of the Priority method to javastyle (like with the rest of the override'd methods in that class)
added cursors for ColorPicker, Rectangle, RoundedRectangle and FreeFormShape tools
Added clone stamp cursor including the alternate "setsource" cursor note that there is a known limitation with this setsource implementation: it will only work as long as the ctrl button is not clicked BEFORE the tool is selected
to Resources/Makefile and to RecolorTool.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi.
additional cursors available.
mostly changes like the other pull request.
BUT:
CloneStampTool has TWO icons. When holding CTRL the alternate one will be shown.
But it will not work all the time:
if somebody has the wicked idea of pressing CTRL BEFORE selecting the tool, the icon will not be changed.
I have not found another way without some serious rework.
I am pretty sure GTK has ways to get the state of the control key without the key event, but I am not familiar with GTK and I did not find it yet.
with that pull request we've got all but 2 cursors.
the only 2 left are the "big" ones.
Erase & Paintbrush.
For both I would want to create a "radius" for the cursor depending on the brush_width, but I guess I would need to do that dynamically when creating the cursor and when the width changes.
Are you aware of already existing functionality I could reuse for that?
with regards,
felix