Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagerduty -- update the new-or-updated-incident trigger #5369

Closed
dannyroosevelt opened this issue Jan 31, 2023 · 2 comments · Fixed by #5418
Closed

Pagerduty -- update the new-or-updated-incident trigger #5369

dannyroosevelt opened this issue Jan 31, 2023 · 2 comments · Fixed by #5418
Assignees
@luancazarine @DilanAthukorala
Labels
enhancement New feature or request help wanted Extra attention is needed triaged For maintainers: This issue has been triaged by a Pipedream employee trigger / source New trigger / source request user request

Comments

@dannyroosevelt
Copy link
Collaborator

dannyroosevelt commented Jan 31, 2023 •
edited by dylburger
Loading

App

Pagerduty
https://developer.pagerduty.com/api-reference/ec247c8767c6d-create-a-webhook-subscription

Triggers

Update the existing new-or-updated-incident trigger to include an optional prop to filter the events based on what Pagerduty supports.

Possible bug

We may not be correctly paginating escalation policies (see this Slack thread). The user reports that we only load 25 policies, and no more. We should paginate behind the scenes and return the full list of options back to the user, instead of returning the offset / more flag back to the async options call.
@dannyroosevelt dannyroosevelt added enhancement New feature or request help wanted Extra attention is needed trigger / source New trigger / source request user request labels Jan 31, 2023
@dannyroosevelt dannyroosevelt changed the title Pagerduty Pagerduty -- update the new-or-updated-incident trigger Jan 31, 2023
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Jan 31, 2023
@sgirones
Copy link

sgirones commented Feb 2, 2023

I may also add that the trigger needs to be updated to Webhooks V3:

image

March 2023 is rather close 😄

With Webhooks V3 you can define what kind of events you want to receive, which would help with this issue too

@dannyroosevelt
Copy link
Collaborator Author

@sgirones thanks for flagging!

@luancazarine luancazarine self-assigned this Feb 2, 2023
luancazarine added a commit that referenced this issue Feb 6, 2023
@luancazarine
Pagerduty -- update the new-or-updated-incident trigger #5369
13cc956 
  - Add optional prop events
  - Fix props pagination
  - Update all webhook integration to V3
@luancazarine luancazarine linked a pull request Feb 6, 2023 that will close this issue
5369 pagerduty update the new or updated incident trigger #5418
Merged
@DilanAthukorala DilanAthukorala self-assigned this Feb 7, 2023
luancazarine added a commit that referenced this issue Feb 10, 2023
@luancazarine
5369 pagerduty update the new or updated incident trigger (#5418)
2c1b270 
* pnpm

* pnpm

* pnpm

* pnpm

* pnpm update

* Pagerduty -- update the new-or-updated-incident trigger #5369
  - Add optional prop events
  - Fix props pagination
  - Update all webhook integration to V3

* bump versions

* fix validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luancazarine luancazarine

@DilanAthukorala DilanAthukorala

Labels
enhancement New feature or request help wanted Extra attention is needed triaged For maintainers: This issue has been triaged by a Pipedream employee trigger / source New trigger / source request user request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5369 pagerduty update the new or updated incident trigger PipedreamHQ/pipedream
5 participants
@dylburger @sgirones @luancazarine @dannyroosevelt @DilanAthukorala