Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Notion - Update Page action: Can not update checkbox property type #6508

Closed
vunguyenhung opened this issue May 16, 2023 · 1 comment · Fixed by #6512
Closed

[BUG] Notion - Update Page action: Can not update checkbox property type #6508

vunguyenhung opened this issue May 16, 2023 · 1 comment · Fixed by #6512
Assignees
@lcaresia
Labels
bug Something isn't working prioritized Prioritized issue triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog

Comments

@vunguyenhung
Copy link
Collaborator

vunguyenhung commented May 16, 2023 •
edited

Describe the bug
Notion - Update Page action: Can not update checkbox property type. First I created a test page with a checkbox property
image

Then on Pipedream, I added the Notion - Update Page action, select the checkbox property, and add the true value
image

Observe the error contains
body.properties.Added to DB.checkbox should be a boolean, instead was "true"``. This part indicates that we are passing true as string to notion instead of boolean

One workaround is using custom expression instead, but it is counter-intuitive
image

Expected behavior

  • We should parse the value in the Property Types prop following the notion property type (instead of always string as currently). For example: checkbox type should be passed in boolean, number type should be passed in number

Additional context
Reported by a user here: https://pipedream-users.slack.com/archives/CMZG4EBJ9/p1684192652423729
@vunguyenhung vunguyenhung added bug Something isn't working prioritized Prioritized issue labels May 16, 2023
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label May 16, 2023
@lcaresia lcaresia self-assigned this May 16, 2023
@lcaresia lcaresia moved this from Prioritized to Doing in Component (Source and Action) Backlog May 16, 2023
@lcaresia lcaresia linked a pull request May 16, 2023 that will close this issue
[BUG] Notion - Update Page action: Can not update checkbox property type #6508 #6512
Merged
@lcaresia lcaresia moved this from Doing to Ready for PR review in Component (Source and Action) Backlog May 16, 2023
@luancazarine luancazarine moved this from Ready for PR review to In Review in Component (Source and Action) Backlog May 16, 2023
@luancazarine luancazarine moved this from In Review to Ready for QA in Component (Source and Action) Backlog May 16, 2023
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 17, 2023
@vunguyenhung
Copy link
Collaborator Author

Hi, I confirm that this fix works as expected

With checkbox = false

image

With checkbox = true

image

@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog May 17, 2023
Component (Source and Action) Backlog automation moved this from Ready for release to Done May 17, 2023
lcaresia added a commit that referenced this issue May 17, 2023
@lcaresia
[BUG] Notion - Update Page action: Can not update checkbox property t…
7e62aed 
…ype #6508 (#6512)

* Fixed checkbox value

* pnpm

* Bump versions

* Bump versions
alysonturing pushed a commit that referenced this issue May 17, 2023
@alysonfreitas
Merge branch 'master' into 6503-bingx-trade-new-order-error
a588d7e 
* master:
  [BUG] Notion - Update Page action: Can not update checkbox property type #6508 (#6512)
  Adding app scaffolding for respond_io
  Adding app scaffolding for respond_io
  Adding app scaffolding for respond_io
  Modifying global config
  Adding app scaffolding for cloze
  Adding app scaffolding for cloze
  Adding app scaffolding for cloze
  Adding app scaffolding for caspio
  Adding app scaffolding for caspio
  Adding app scaffolding for caspio
  Modifying global config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcaresia lcaresia

Labels
bug Something isn't working prioritized Prioritized issue triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Notion - Update Page action: Can not update checkbox property type #6508 PipedreamHQ/pipedream
4 participants
@dylburger @lcaresia @vunguyenhung and others