Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Notion - Update Page action: Can not update checkbox property type #6508 #6512

Merged
merged 5 commits into from May 17, 2023

Conversation

lcaresia
Copy link
Collaborator

@lcaresia lcaresia commented May 16, 2023

WHAT

🤖 Generated by Copilot at 48d1a58

This pull request updates the pnpm-lock.yaml file and fixes a bug in the notion component. The bug affected the checkbox property type in the update page action and was resolved by improving the value conversion logic. The pull request also adds a new append block action to the notion component.

🤖 Generated by Copilot at 48d1a58

We fixed a bug in update page action
That caused some checkbox type confusion
We also added append block
And updated the notion package lock
To sync with the latest component fusion

WHY

HOW

🤖 Generated by Copilot at 48d1a58

  • Incremented version of update page action and notion component package to reflect bug fix and new feature (link, link)
  • Fixed bug in convertToNotion function for checkbox property type to handle falsy values better (link)
  • Added focuster component and removed omniconvert component from pnpm-lock.yaml file as part of separate pull requests (link, link)

@lcaresia lcaresia added the bug Something isn't working label May 16, 2023
@lcaresia lcaresia self-assigned this May 16, 2023
@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 3:25pm
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 3:25pm

Copy link
Collaborator

@luancazarine luancazarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lcaresia, thanks for your contribution! LGTM!

@lcaresia lcaresia merged commit 7e62aed into master May 17, 2023
10 checks passed
@lcaresia lcaresia deleted the notion-checkbox branch May 17, 2023 11:56
alysonturing pushed a commit that referenced this pull request May 17, 2023
* master:
  [BUG] Notion - Update Page action: Can not update checkbox property type #6508 (#6512)
  Adding app scaffolding for respond_io
  Adding app scaffolding for respond_io
  Adding app scaffolding for respond_io
  Modifying global config
  Adding app scaffolding for cloze
  Adding app scaffolding for cloze
  Adding app scaffolding for cloze
  Adding app scaffolding for caspio
  Adding app scaffolding for caspio
  Adding app scaffolding for caspio
  Modifying global config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Notion - Update Page action: Can not update checkbox property type
2 participants