Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache is not working in ContentService #1697

Closed
tidyui opened this issue Aug 23, 2021 · 3 comments
Closed

Cache is not working in ContentService #1697

tidyui opened this issue Aug 23, 2021 · 3 comments
Assignees
@tidyui
Labels
bug core
Milestone
Version 10.4

Comments

@tidyui
Copy link
Member

tidyui commented Aug 23, 2021

The cache is commented out in the GetById() method in the ContentService. See #1696 for reference.
@tidyui tidyui added this to the Version 9.2 milestone Aug 23, 2021
@tidyui tidyui self-assigned this Aug 23, 2021
@tidyui
Copy link
Member Author

tidyui commented Aug 23, 2021 •
edited
Loading

Also, tests should be added for the ContentService with both MemoryCache & DistributedCache.

@tidyui tidyui closed this as completed in 04b4fff Aug 23, 2021
@hrvoje-grabusic
Copy link

The cache commented probably because it uses the same key for every language.

@tidyui tidyui reopened this Aug 26, 2021
tidyui added a commit that referenced this issue Oct 7, 2021
@tidyui
Reverted 04b4fff. See #1697
39382d0
@tidyui tidyui removed this from the Version 9.2 milestone Oct 7, 2021
@david-tretton37
Copy link

Any updates on this?

@tidyui tidyui added this to the Version 10.4 milestone Jan 31, 2023
@tidyui tidyui closed this as completed in 9296bd7 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tidyui tidyui

Labels
bug core
Projects
No open projects
Version 10.4
Status: Done
Milestone
Version 10.4
Development

No branches or pull requests
3 participants
@tidyui @hrvoje-grabusic @david-tretton37