Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spinning Square Build Status Badge #5

Closed
indiv0 opened this issue Aug 21, 2014 · 6 comments · Fixed by #6
Closed

Fix Spinning Square Build Status Badge #5

indiv0 opened this issue Aug 21, 2014 · 6 comments · Fixed by #6

Comments

@indiv0
Copy link
Member

indiv0 commented Aug 21, 2014

The Spinning Square tutorial build status badge is currently broken.

https://github.com/PistonDevelopers/Piston-Tutorials/blob/master/getting-started/readme.md#spinning-square-

Perhaps it should be removed in favor of the one on the main README.md?

@indiv0
Copy link
Member Author

indiv0 commented Aug 26, 2014

@TyOverby thoughts?

@TyOverby
Copy link
Contributor

Oh yes, it should be replaced. This project changed domains, and it looks
like we only updated one of the urls.

I wouldn't make many more changes to this repo in the mean time, I've been
working on tools for maintaining and creating tutorials, and when those are
released, we'll have a large update.
On Tue, Aug 26, 2014 at 11:17 AM Nikita Pekin notifications@github.com
wrote:

@TyOverby https://github.com/TyOverby thoughts?


Reply to this email directly or view it on GitHub
#5 (comment)
.

@indiv0
Copy link
Member Author

indiv0 commented Aug 26, 2014

Alright then, I'll leave this as-is, pending the tools.

@TyOverby
Copy link
Contributor

Actually, since the Travis build tests the entire repository, maybe the
non-global one should just be removed.
On Tue, Aug 26, 2014 at 11:39 AM Nikita Pekin notifications@github.com
wrote:

Alright then, I'll leave this as-is, pending the tools.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@indiv0
Copy link
Member Author

indiv0 commented Aug 26, 2014

I'll make a PR then.

Just remove the badge from the tutorial, right?

@TyOverby
Copy link
Contributor

Yeah
On Tue, Aug 26, 2014 at 11:44 AM Nikita Pekin notifications@github.com
wrote:

I'll make a PR then.

Just remove the badge from the tutorial, right?


Reply to this email directly or view it on GitHub
#5 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants