better custom packs support + import chibisafe albums as custom packs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 30, 2022 14:08
with backwards-compatibility
added a new section for chibisafe album urls
images.weserv.nl still doesn't support APNG -> GIF, but if one day... also magane proxy doesn't have hasAnimation prop for emoji packs yet
so that it will always be able to fallback to file emoji even if the entire album is made of non-image/video files
styling + error handling
to facilitate updates without having to delete the packs first
prevent it from closing when clicking things on bdapi modals
partial properties overwrites is now only enabled with an extra toggle
removed overwrite flag from window.appendCustomPack() overwriting in itself requires extra steps such as double-checking favorites and subscribed pack data, but that will be relegated to the update pack feature window.magane.editPack() is then added for those that still want to modify some properties, but due to its nature as a console function, it's meant for the more advanced users that can handle the consequences
unified the feature into supporting all remote packs altogehter where non-chibisafe album packs will be imported with JSON config file also wrote it in a way that allows easy & clean expansion if required additionally, adding custom packs will now be presented with a simple consent confirmation we never know if fetching third-party url and trying to parse its body as json can somehow be abused by bad actors
BobbyWibowo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As always, I try to do micro commits, so despite the high commit counts, each commit tries to do the bare minimum
3 new settings
My custom packs for sample valid JSONs of non-chibisafe album packs https://magane.fiery.me/configs/