Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade datatables js #378

Closed
modus75 opened this issue Dec 1, 2015 · 2 comments
Closed

upgrade datatables js #378

modus75 opened this issue Dec 1, 2015 · 2 comments
Assignees
@modus75
Milestone
2.9.0beta1

Comments

@modus75
Copy link
Contributor

modus75 commented Dec 1, 2015

not very straightforward because api functions have changed names (no more hungarian notation)

need to do user list and rating users.
@plegall
Copy link
Member

plegall commented Dec 1, 2015

Yes, I saw yesterday (while implementing a dataTable for plugin Private Share) that API functions now have new (and better) names.

Please do it on a branch and I will handle the user list.

@plegall plegall added this to the 2.9.0beta1 milestone Jan 9, 2016
@modus75 modus75 self-assigned this Jan 23, 2016
@modus75
Copy link
Contributor Author

modus75 commented Jan 23, 2016

I saw it's backward compatible so I will wait until 2.8 is released and then commit it directly on master ...

@plegall plegall mentioned this issue Feb 13, 2016
Closed
modus75 added a commit that referenced this issue Feb 18, 2016
@modus75
upgrade datatables to 1.10.11 (issue #378)
8b51eb1
modus75 added a commit that referenced this issue Mar 9, 2016
@modus75
issue #378 upgrade datatables to 1.10.11
8c1a4a1
@modus75 modus75 closed this as completed Mar 9, 2016
plegall added a commit that referenced this issue Dec 9, 2016
@plegall
feature #378, bug fixed on draw() call
806a3b7 
The oTable javascript variable is built with jQuery('#userList').dataTable(),
which returns a jQuery object, while jQuery(...).Datatable() would directly
return a DataTables API object. So now, to access the draw() function, we need
to get the api() first from the jQuery object.

https://datatables.net/manual/api#Accessing-the-API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modus75 modus75

Labels
None yet
Projects
None yet
Milestone
2.9.0beta1
Development

No branches or pull requests
2 participants
@plegall @modus75