Improved patch approximations around non-manifold features #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use regular corner patches around non-manifold verts that were sharpened
|
It seems we could add better comments and add some symbol names for the magic numbers in PatchTable factory, but this change is just following the existing pattern. It would be nice to clean this up in the future though, to lower the barrier to entry for new engineers... |
jcowles
added a commit
that referenced
this pull request
Sep 28, 2015
Improved patch approximations around non-manifold features
|
Agreed. When we deal with infinitely sharp features better (hopefully On Mon, Sep 28, 2015 at 9:53 AM, Jeremy Cowles notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches around non-manifold vertices are currently approximated with regular patches, which works well in some cases but not all. Ultimately we need irregular patches (or at least some kind of extrapolated regular patch) to represent these without cracks, which is planned for the future.
Until then, this change uses regular corner patches around non-manifold vertices that are sharpened to interpolate the vertex and reduce cracks between the patches around it. This does not eliminate cracks with the adjacent interior patches, but it is hoped the isolation level is deep enough to make them negligible until the longer term solution is in place.