-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Language Support #55
Conversation
### Description of Proposal This proposal adds a human language local to USD so that content may be localized or provide hints for assistive technologies. [Link to Rendered Proposal](https://github.com/dgovil/USD-proposals/blob/language/proposals/language/README.md) ### Disclaimer This proposal isn't representative of upcoming functionality in our products. This is a future looking proposal that seemed timely to augment the proposals by others here like Autodesk. This builds on discussion in [Issue 49](PixarAnimationStudios#49) ### Supporting Materials An example ``` def Foo( prepend apiSchemas = ["LocaleAPI"] language = "en_US" ) { string text = "There's a snake in my boot" string text:fr_CA = "Il y a un serpent dans ma botte" string text:hi = "मेरे जूते में एक सांप है" } ``` ### Contributing - [X] I agree to and accept the [Supplemental Terms](https://graphics.pixar.com/usd/release/contributing_supplemental.html).
I understand the usage of this language id now. The proposal looks good to me. I have one suggestion for the fallback behavior. In my opinion, if an attribute doesn't specify a language, it is a fallback for any language. Its language can be inferred by the runtime or the system locale, but we also need to allow the user know that it is a fallback. For example, |
Ah yeah that makes sense. I'll add in the wording accordingly. |
@PierreWang I think the comment from Dhruv in the other thread ran along the lines of "we can't infer based on codepoints because of ambiguity". When you say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor editorial comments. Looks good overall. Thanks!
Just plussing that, in case @PierreWang meant infer from the text itself... if the text were instead "Lorries are awesome", it's not reasonable for a DCC to infer that's |
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis looks great, @dgovil - just a couple requests for clarification.
Thanks for the feedback, @cookiecrook and @spiffmon . I've made the changes accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to move to draft
Description of Proposal
This proposal adds a human language local to USD so that content may be localized or provide hints for assistive technologies.
Link to Rendered Proposal
Disclaimer
This proposal isn't representative of upcoming functionality in our products. This is a future looking proposal that seemed timely to augment the proposals by others here like Autodesk.
This builds on discussion in Issue 49
Supporting Materials
An example
Contributing