-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the rate_diff_transformation function. #138
Adding the rate_diff_transformation function. #138
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #138 +/- ##
========================================
+ Coverage 0 81.81% +81.81%
========================================
Files 0 118 +118
Lines 0 6560 +6560
========================================
+ Hits 0 5367 +5367
- Misses 0 1193 +1193 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice and clean! I had a small comment on the formatting of the doc sting. The other thing I think would be good to do is to add a simple test for rate_diff_tranformation
. Lets fix that and then I think we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super!
rate_diff_transformation is an alternative transformation that has been shown to improve the raw pearson values for colocalization analysis especially in terms of removing the correlation between colocalization values and marker abundance. It is now being added as an option but will not be set as the default transformation yet for colocalization analysis (the default is currently log1p).
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a unit-test for colocalization calculation with rate-diff transformation to verify run without errors. The colocalization values with rate-diff transformation are also checked for different datasets and are shown to result in high agreement between raw pearson values and pearson_z scores and expected biological signals such as HLA-ABC with B2M and CD11a and CD18 appear consistently in top marker pairs.
There will be further inspection and comparison before setting this transformation as default.
PR checklist: