Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly check marker value expressions to be greater than zero bef… #140

Merged
merged 3 commits into from
May 17, 2024

Conversation

ptajvar
Copy link
Contributor

@ptajvar ptajvar commented May 17, 2024

Small fix of Jaccard index to work also with the rate-diff. It works with boolean values and any non-zero value, including negative values is mapped to True. So adding an explicit check that the value is greater than zero fixes the issue for rate-diff and other potential transformations that may yield negative values.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Multiple samples have been run after the fix. The Jaccard index works as before with log1p and now also works with rate-diff.

PR checklist:

  • This comment contains a description of changes (with reason).

…ore converting to boolean for jaccard index calculation
@ptajvar ptajvar self-assigned this May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (00be3d6) to head (9a8a42b).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #140      +/-   ##
==========================================
- Coverage   81.81%   81.76%   -0.05%     
==========================================
  Files         118      118              
  Lines        6560     6560              
==========================================
- Hits         5367     5364       -3     
- Misses       1193     1196       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptajvar ptajvar merged commit 5fb97ff into dev May 17, 2024
14 of 15 checks passed
@ptajvar ptajvar deleted the fix/jaccard-index-setting-negative-marker-values-to-true branch May 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants