explicitly check marker value expressions to be greater than zero bef… #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix of Jaccard index to work also with the rate-diff. It works with boolean values and any non-zero value, including negative values is mapped to True. So adding an explicit check that the value is greater than zero fixes the issue for rate-diff and other potential transformations that may yield negative values.
Type of change
How Has This Been Tested?
Multiple samples have been run after the fix. The Jaccard index works as before with log1p and now also works with rate-diff.
PR checklist: