Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #352

Merged
merged 36 commits into from
Feb 22, 2022
Merged

Fixes #352

merged 36 commits into from
Feb 22, 2022

Conversation

@flabbet flabbet requested a review from Equbuxu February 17, 2022 17:41
@flabbet flabbet marked this pull request as ready for review February 17, 2022 17:41
Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move tool and move viewport tool seem to work fine, #351 still isn't fixed

@flabbet flabbet requested a review from Equbuxu February 18, 2022 18:51
@flabbet
Copy link
Member Author

flabbet commented Feb 18, 2022

Fixed

Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A bug with shortcuts:
  1. Select the pen tool
  2. Press space and move the canvas a bit
  3. Release space
  4. Press E (don't hold it down) to switch to the eraser tool

Expected result: the eraser tool should be selected
Actual result: the eraser tool is briefly selected while the E key is down and then the selection goes back to the pen tool.

@flabbet
Copy link
Member Author

flabbet commented Feb 19, 2022

Fixed both

@flabbet flabbet requested a review from Equbuxu February 20, 2022 10:10
Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image preview in the taskbar doesn't seem to be updated when you make a new document (or open an existing one). Not really sure if that's a bug. All else seems good

@Equbuxu
Copy link
Member

Equbuxu commented Feb 20, 2022

nvm I broke something somehow

@Equbuxu
Copy link
Member

Equbuxu commented Feb 20, 2022

9qFPrAHx46.mp4

Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The taskbar image preview is empty when loading a regular (non-.pixi) image
  • Selection tool doesn't work, neither does Ctrl+A nor the move tool
  • Crash when drawing on a pasted layer:
  1. Paste an image
  2. Draw something on the new layer
  3. Undo 2x
  4. Redo 2x
  • A similar crash when deleting a pasted layer
  1. Paste an image
  2. Delete the pasted layer
  3. Undo all the way
  4. Redo all the way
    It seems like any manipulations with the pasted layer cause pixieditor to crash in a similar way.

@flabbet flabbet requested a review from Equbuxu February 20, 2022 17:48
Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z7nDV6Cc49.mp4

@flabbet flabbet requested a review from Equbuxu February 21, 2022 17:32
@flabbet flabbet linked an issue Feb 21, 2022 that may be closed by this pull request
@flabbet flabbet merged commit 0f6a398 into master Feb 22, 2022
@flabbet flabbet deleted the v0.1.7.1-fixes branch February 22, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment