Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevented drag drop race condition #372

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Prevented drag drop race condition #372

merged 3 commits into from
Feb 25, 2022

Conversation

flabbet
Copy link
Member

@flabbet flabbet commented Feb 23, 2022 •
edited

The bug was caused by drag drop of textbox selection (inside layer or group name). PixiEditor tried to drag drop layer when textbox was already drag dropping. This caused WPF to freak out.

Repro of fixed bug:

  1. Select word 'Base' in 'Base Layer'
  2. Try drag dropping outside layer

Also disabled shared toolbar

@flabbet flabbet requested a review from Equbuxu February 23, 2022 20:31
@flabbet flabbet changed the title dPrevented drag drop race condition orevented drag drop race condition Feb 23, 2022
@flabbet flabbet changed the title orevented drag drop race condition Prevented drag drop race condition Feb 24, 2022
@flabbet flabbet merged commit 3a826a5 into master Feb 25, 2022
@flabbet flabbet deleted the drag-drop-fixes branch February 25, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Equbuxu Equbuxu Equbuxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flabbet @Equbuxu