Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the center issue. #408

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

PtrStruct
Copy link

Pull Requests

#406

The titlebar items were not aligned, so I fixed the margins.

Pull request rules:

  1. Clearly describe changes, as detailed as possible
  2. If possible, show examples of usage
  3. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
  4. Make sure all tests are passing.

@PtrStruct
Copy link
Author

PtrStruct commented Jul 2, 2022

Is it common for it to fail the Azure pipeline build? Or did I miss something super obvious?

@Equbuxu
Copy link
Member

Equbuxu commented Jul 2, 2022

Is it common for it to fail the Azure pipeline build? Or did I miss something super obvious?

Yeah, don't worry about the pipelines, they've been failing for a while now for some non-obvious reason

@Equbuxu
Copy link
Member

Equbuxu commented Jul 2, 2022

Looks good to me, here is a quick comparison for others to check out

2el9R7PkwL.mp4

@PtrStruct
Copy link
Author

Thanks for posting a before and after video! I realized my PR message was pretty vague and I should of done what you just did to begin with. Either way, it's much appreciated!

@flabbet flabbet merged commit 5cc372f into PixiEditor:master Jul 2, 2022
@PtrStruct PtrStruct deleted the #406-fix-center-titlebar branch July 2, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants