Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed .hex parser saving colors in bad hex format #541

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fixed .hex parser saving colors in bad hex format #541

merged 1 commit into from
Jun 2, 2023

Conversation

flabbet
Copy link
Member

@flabbet flabbet commented Jun 2, 2023

@flabbet flabbet requested review from Equbuxu and CPKreu June 2, 2023 21:47
CPKreu
CPKreu approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@CPKreu CPKreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but it looks like it should be working. Code also looks quite clean but more comments would be really helpful next time

@flabbet flabbet merged commit 0726b6b into master Jun 2, 2023
@flabbet flabbet deleted the hex-parser-saving-fix branch June 2, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPKreu CPKreu CPKreu approved these changes

@Equbuxu Equbuxu Awaiting requested review from Equbuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flabbet @CPKreu