Added Settings (user preferences) menu #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPKreu
reviewed
Nov 30, 2020
PixiEditor/Views/MainWindow.xaml
Outdated
| @@ -83,6 +83,8 @@ | |||
| Command="{Binding FileSubViewModel.SaveDocumentCommand}" CommandParameter="AsNew" /> | |||
| <MenuItem Header="_Export" InputGestureText="Ctrl+Shift+Alt+S" Command="{Binding FileSubViewModel.ExportFileCommand}" /> | |||
| <Separator /> | |||
| <MenuItem Header="_Settings" Command="{Binding MiscSubViewModel.OpenSettingsWindowCommand}" /> | |||
There was a problem hiding this comment.
I would expect it to be in the Edit tab
There was a problem hiding this comment.
I was thinking about that, some software has this in File some in Edit. Not sure which one should we use.
| Executed="CommandBinding_Executed_Close" /> | ||
| </Window.CommandBindings> | ||
|
|
||
| <Grid Background="{StaticResource AccentColor}"> |
There was a problem hiding this comment.
Might look better if you switch the colors
Suggested change
| <Grid Background="{StaticResource AccentColor}"> | |
| <Grid Background="{StaticResource MainColor}"> |
| <Button Style="{StaticResource DarkRoundButton}" Margin="10 5 10 5" | ||
| Command="{Binding SelectCategoryCommand}" CommandParameter="Updates">Updates</Button> | ||
| </StackPanel> | ||
| <Grid Grid.Row="1" Grid.Column="1" Background="{StaticResource MainColor}"> |
There was a problem hiding this comment.
Suggested change
| <Grid Grid.Row="1" Grid.Column="1" Background="{StaticResource MainColor}"> | |
| <Grid Grid.Row="1" Grid.Column="1" Background="{StaticResource AccentColor}"> |
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 52.31% 52.30% -0.01%
==========================================
Files 179 186 +7
Lines 6354 6504 +150
Branches 559 570 +11
==========================================
+ Hits 3324 3402 +78
- Misses 2916 2983 +67
- Partials 114 119 +5
Continue to review full report at Codecov.
|
CPKreu
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Settings menu in
File -> Settingswith settings:Of course, added
user_preferences.jsonreader and writer. The file is stored underAppData\Local\PixiEditor\user_preferences.json