add system status check #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmrico
requested changes
Apr 12, 2022
plansys2_popf_plan_solver/src/plansys2_popf_plan_solver/popf_plan_solver.cpp
Outdated
Show resolved
Hide resolved
fmrico
approved these changes
Apr 12, 2022
|
was not as easy as expected |
|
Yes!! You can click on the details of the check that failed. If you analyze the log (it is better to see the raw logs) you will see that some linting tests didn't pass. You could have detected this by running: Thanks for your time!! |
|
Any advance on this PR? Best |
|
there was not much free time for it. |
|
Hi, @fmrico |
|
LGTM!! Merging 🚀 Thanks @Splinter1984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#214