Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webview downloads #40

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Add webview downloads #40

merged 4 commits into from
Aug 2, 2022

Conversation

kailuo
Copy link
Contributor

@kailuo kailuo commented Aug 1, 2022 •
edited
Loading

Support basic download tasks in article web view:

  • Added a downloads window
  • Updated web view navigation policy for downloading file and opening link in system browser
  • Fixed a navigation policy issue to handle link with target="_blank" tag

TODO:

  • Remove (patch) context menu in article web view, currently options like download linked file is not working
  • Add more MIME types
  • Handle downloads history
  • Handle failed download task

@livid livid merged commit cd6e60a into main Aug 2, 2022
@kailuo kailuo mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kailuo @livid