Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix installer versioning in CI OS builds outside PRs #421

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ethanjli
Copy link
Member

@ethanjli ethanjli commented Jun 7, 2024

This PR follows up on #416 by trying to fix CI OS builds in the merge queue (which currently all fail, as in 64120a1).

@ethanjli ethanjli marked this pull request as ready for review June 7, 2024 02:01
@ethanjli
Copy link
Member Author

ethanjli commented Jun 7, 2024

The only way to test whether this PR fixes behavior in the merge queue is to send it to the merge queue, so I will do that by merging this PR.

@ethanjli ethanjli enabled auto-merge June 7, 2024 02:02
@ethanjli ethanjli changed the title Try to fix installer versioning in merge queue-triggered CI OS builds Try to fix installer versioning in CI OS builds outside PRs Jun 7, 2024
@ethanjli ethanjli added this pull request to the merge queue Jun 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 7, 2024
@ethanjli ethanjli added this pull request to the merge queue Jun 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 7, 2024
@ethanjli ethanjli added this pull request to the merge queue Jun 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 7, 2024
@ethanjli ethanjli added this pull request to the merge queue Jun 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 7, 2024
@ethanjli ethanjli added this pull request to the merge queue Jun 7, 2024
Merged via the queue into master with commit 392da19 Jun 7, 2024
4 checks passed
@ethanjli ethanjli deleted the fix/ci-merge-queue-os-builds branch June 7, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant