Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO_331:0000218 id is duplicated #6

Closed
bellerbrock opened this issue Nov 11, 2016 · 8 comments
Closed

CO_331:0000218 id is duplicated #6

bellerbrock opened this issue Nov 11, 2016 · 8 comments

Comments

@bellerbrock
Copy link
Contributor

CO_331:0000218 is used as the id for both Storage root total marketable yield weight computation tons per ha and Weight of commercial storage roots. This is causing a conflict in sweetpotatobase (and maybe is also why the Weight of commercial storage roots trait is not visible on crop ontology?)

How can this be resolved? Weight of commercial storage root data is already stored in sweetpotatobase, so the temporary solution has been to exclude Storage root total marketable yield weight computation tons per ha from the working obo file.

@jaiswalp
Copy link

@elizabetharnaud @marieALaporte @cooperl09 Please check.

@cooperl09
Copy link
Member

That ID is not in the the sweet potato ontology file which is in this repository. It looks like it was updated on the https://sweetpotatobase.org/ site in Sept. 2016. The files here have not been updated since Nov. 2015.

@jaiswalp
Copy link

This is interesting. Idea was to have all the edits recorded using the version control. Please confirm.

@bellerbrock
Copy link
Contributor Author

@cooperl09 Right, the files on the master branch here haven't been updated since last fall. Maybe @c5sire or @omarbenites can push the edits and updates?

@cooperl09
Copy link
Member

OK, That would be good. I can help if there are issues, or @marieALaporte could upload it as well.

@bellerbrock
Copy link
Contributor Author

Ok, thanks. For background, to my knowledge the latest version was released in June 2016 on cropontology.org. There is a TraitDictionary file of that release that @c5sire sent me stored here in the sweetpotatobase branch. In September I converted it to .obo format with @marieALaporte in order to load it into sweetpotatobase. Problems like this showed up during that process, and new traits have been requested since. I don't know if this is the appropriate forum, but I thought I should at least track the issues somewhere where others can see!

@jaiswalp
Copy link

This is the right forum as we build resources.

Pankaj

On 11/17/2016 11:44 AM, Bryan Ellerbrock wrote:

Ok, thanks. For background, to my knowledge the latest version was
released in June 2016 on cropontology.org. There is a TraitDictionary
file of that release that @c5sire https://github.com/c5sire sent me
stored here in the sweetpotatobase branch. In September I converted it
to .obo format with @marieALaporte https://github.com/marieALaporte
in order to load it into sweetpotatobase. Problems like this showed up
during that process, and new traits have been requested since. I don't
know if this is the appropriate forum, but I thought I should at least
track the issues somewhere where others can see!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHCSQNJdw6s5KRkwSp_ds17dmyTkMvAdks5q_K67gaJpZM4KvVh3.

Pankaj Jaiswal, PhD
ICBO 2016 Conference Chair
Associate Professor
Oregon State University
Department of Botany and Plant Pathology
2082 Cordley Hall
Corvallis, OR-97331
USA
email: jaiswalp@oregonstate.edu

bellerbrock added a commit that referenced this issue Nov 30, 2016
…per ha' to working obo file with next id in sequence to address issue #6
@bellerbrock
Copy link
Contributor Author

Fixed this is the working obo file by readding Storage root total marketable yield weight computation tons per ha with a different id. And closing it now as we're making the working obo file the new master file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants