Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes from refurb and ruff to plasmapy.particles #1846

Merged
merged 4 commits into from
Dec 21, 2022

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Dec 21, 2022

This PR follows up on #1845 by applying changes from refurb and ruff to plasmapy.particles.

@github-actions
Copy link

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@namurphy namurphy requested a review from a team as a code owner December 21, 2022 04:54
@namurphy namurphy requested review from StanczakDominik and removed request for a team December 21, 2022 04:54
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 98.33% // Head: 98.33% // No change to project coverage 👍

Coverage data is based on head (a606133) compared to base (5eda6f1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1846   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          95       95           
  Lines        8343     8343           
=======================================
  Hits         8204     8204           
  Misses        139      139           
Impacted Files Coverage Δ
plasmapy/particles/atomic.py 98.64% <ø> (ø)
plasmapy/particles/ionization_state.py 94.92% <ø> (ø)
plasmapy/particles/_factory.py 100.00% <100.00%> (ø)
plasmapy/particles/_parsing.py 98.44% <100.00%> (ø)
plasmapy/particles/ionization_state_collection.py 91.90% <100.00%> (ø)
plasmapy/particles/particle_class.py 98.49% <100.00%> (ø)
plasmapy/particles/particle_collections.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@namurphy namurphy changed the title Apply changes from refurb to plasmapy.particles Apply changes from refurb and ruff to plasmapy.particles Dec 21, 2022
@StanczakDominik StanczakDominik merged commit 822b9cc into PlasmaPy:main Dec 21, 2022
@namurphy namurphy deleted the refurb-particles branch December 21, 2022 17:04
@namurphy namurphy added plasmapy.particles Related to the plasmapy.particles subpackage linters Code linters and autoformatters labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linters Code linters and autoformatters plasmapy.particles Related to the plasmapy.particles subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants